Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change f2 to be exch instead of # #119

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

tekenny
Copy link
Collaborator

@tekenny tekenny commented Nov 12, 2022

This PR is for issue #58.

I've included the VCL files that I needed to be able to build and execute MR via Delphi IDE.

Please let me know if you have any questions or concerns.

@tekenny tekenny added the bug Something isn't working label Nov 12, 2022
@tekenny tekenny requested review from scotthibbs and w7sst November 12, 2022 18:50
@tekenny tekenny self-assigned this Nov 12, 2022
@w7sst w7sst requested a review from ct7aup November 12, 2022 19:10
@w7sst w7sst self-requested a review November 13, 2022 06:52
@w7sst
Copy link
Owner

w7sst commented Nov 13, 2022

Hi Tom, @tekenny
So what is your recommended process here... You have submitted a PR to our main branch and I have reviewed it. Do I perform the merge, or do you perform the merge? What process do you recommend on who performs the merge on a project like this?

I'm new to open source projects, so I'm open to best practices and recommendations. I just realized that when you submit PR, the action is probably back on me to do the merge. Just wondering what your thoughts are on this one.

We should probably document this process in our Pull Requests section of our CONTRIBUTING.md page.

@tekenny
Copy link
Collaborator Author

tekenny commented Nov 15, 2022

Sorry for the delay, it has been very busy the last couple of days.

My experience with open source projects has been that anybody that wants to contribute forks the (upstream) repo.
They make a branch in their forked repo for the change and then create a pull request from the branch in their repo to the upstream repo.
The upstream repo protects merges to one or a very limited set of moderators to keep control on accepting consistentancy and quality.
In my opinion since we are small you @w7sst would be the person performing merges as anything accepted should match your vision for this repo. If the set of contributors grows greatly you may want to have others help.
IMHO if you let any of us to do merges choas could happen. Realistically this probably won't happen right now, since there is allot of discussions about the issues and changes being made and why we are doing things in the way we are doing them. But it is always possible that at one point a contributor could join that isn't as communitive, or wants things their way and that could disrupt things.

I hope this helps. Mike the decision is yours and I'll abide by it. Of course let me know if you have any questions or concerns with what I've stated. I'll be happy to create an issue to update Pull Requests section in CONTRIBUTING.md once you decide how you want to manage this repo.

@tekenny
Copy link
Collaborator Author

tekenny commented Nov 15, 2022

PS - I'll try to find a web page to reference as well regarding what I've stated. Meaning summary in CONTRIBUTING doc but also a link to a more extensive explanation to support the summary...

@w7sst
Copy link
Owner

w7sst commented Nov 16, 2022

I hope this helps. Mike the decision is yours and I'll abide by it. Of course let me know if you have any questions or concerns with what I've stated. I'll be happy to create an issue to update Pull Requests section in CONTRIBUTING.md once you decide how you want to manage this repo.

Tom @tekenny, yes this helps and confirms my role. Like I said, this is my first time contributing to an open source project and I'm also trying to grow a community to support MR. This is starting slow and it starting to gain steam - I'm encouraged. I'll look into collaborator permissions to see if we can control who can perform the merges. I like the idea of keeping control of the merges so we can keep the project heading in a consistent direction.

@tekenny
Copy link
Collaborator Author

tekenny commented Nov 17, 2022

@w7sst no worries, I'm happy to help. Let me know if you need any help with admin of the repo. Also feel free to merge this PR.

@w7sst w7sst merged commit 027fa81 into w7sst:main Nov 17, 2022
@w7sst
Copy link
Owner

w7sst commented Nov 17, 2022

Merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants